Unify BN254 naming #9004
Merged
Unify BN254 naming #9004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
approved these changes
Jul 17, 2025
Contributor
|
BN->Bn 😁 |
Contributor
Author
This was on purpose. According to Microsoft's naming convention, two-letter abbreviations are all uppercase, while 3+ are just capitalized. This said, they aren't always consistent with their own convention -- |
Demuirgos
pushed a commit
that referenced
this pull request
Jul 21, 2025
* Update CLZ gas cost for devnet3 (#8953) * Update tx gas cap for devnet3 (#8954) * Don't block background tasks when syncing (#8971) * Don't block background tasks when syncing * fix test * fix compile warning * Concurrency 2 * Rename blob metrics (#8972) * Fix Taiko Engine Api (#8974) * Better null-ckecks in TryGetCanonicalTransaction (#8969) * Better null-ckecks in TryGetCanonicalTransaction * fix test * fix whitespace * fix test * Revise JSON-RPC docs generation (#8967) * Fix/OOM when downloading from genesis. (#8975) * Slight change in constructor * Stop putting more request when queue is high * Add unit test * Set budget as memory * Whitespace * Fix test * Cache PropertyInfo lookups for JsonRpc (#8976) * Auto-update fast sync settings (#8978) Co-authored-by: rubo <rubo@users.noreply.github.com> * Update OP Superchain chains (#8979) Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com> * Remove use of Linq.Sum from hot paths (#8977) * Remove use of Linq.Sum from hot paths * Simplify * Isolate Tracer in Proof Module and remove IVisitingWorldState (#8981) * Scope the tracer * Use state reader in Tracer * Inline dump state * Remove accept * Delete IVisitingWorldState * Move dump state to state reader * Whitespace * More hot code in ConnectNodes (#8982) * Only access "warmup" hashtable once per warmup (#8983) * Only access "warm" up hashtable once per warmup * Update src/Nethermind/Nethermind.Evm/Instructions/EvmInstructions.cs Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> --------- Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> * EIP-7594: Constant maxBlobsPerTx (#8940) * Const maxBlobsPerTx * WS * Add tests(improve for the Gnosis case); add link * Fail fast on Db corruption (#8986) * Fail fast on Db corruption * Fix tests * Update src/Nethermind/Nethermind.Db.Rocks/DbOnTheRocks.cs Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> --------- Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> * Configure EWC Zurich hard fork (#8985) * feat: Add RegexOptions.Compiled flag to NewPayloadJsonRpcValidator (#8984) * Improve locking when looking up RlpDecoders (#8987) * Remove locking in RlpDecoder fast path * Feedback * Fix naming of data cost in ExecutePrecompile (#8994) fix naming of data cost * Move precompiles (#8962) * Move precompiles * Fix build * Fix formating * EthereumCodeInfoRepository * Remove EthereumPrecompiles class * Move precompiles into separate project * Fix build * Add EIP-7910: Add eth_config (#8956) * Add eth_config * Update systemContracts, refactor * Fix next/last hash to be null * Replace `eth_pairings` with `mcl` (#8992) * Unify BN254 naming (#9004) * Refactor/Move init DB to DI (#8997) * Wait to read channel before reading * Fix BN254 point deserialization (#9009) * Optimize ModExp (#9008) * Optimize ModExp * Faaster * Moar * work as nuint * use nint * cast via int * Remove unneeded casts * Move OldRuns to tests * fix benchmarks * Feedback * Less branches * Less branches * fixed invalid * Remove last orphan readonly tx processing scope. (#9005) * Fix workerloop * Replace read all with try read * Update config for tests * Update winget command (#9011) * Auto-update fast sync settings (#9013) Co-authored-by: rubo <rubo@users.noreply.github.com> * Update OP Superchain chains (#9014) Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com> * Tidy up ecdsa overloads (#9015) * Tidy up ecdsa overloads * put back the increase * Tracing check to allow ilevm to be enabled for node and tests * Update verified * .. --------- Co-authored-by: Ben {chmark} Adams <thundercat@illyriad.co.uk> Co-authored-by: Alexey <me@flcl.me> Co-authored-by: Amirul Ashraf <asdacap@gmail.com> Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> Co-authored-by: core-repository-dispatch-app[bot] <173070810+core-repository-dispatch-app[bot]@users.noreply.github.com> Co-authored-by: emlautarom1 <emlautarom1@users.noreply.github.com> Co-authored-by: Micke <155267459+reallesee@users.noreply.github.com> Co-authored-by: Marcin Sobczak <77129288+marcindsobczak@users.noreply.github.com> Co-authored-by: Nikita Mescheryakov <root@nikitam.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Renamed the incorrect
Bn128Enabledproperty toBN254Enabledto avoid confusion.Types of changes
What types of changes does your code introduce?
Testing
Requires testing